Clarify attributes parameter type of Get a Logger operation #3841
Assignees
Labels
[label deprecated] triaged-accepted
[label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR
spec:logs
Related to the specification/logs directory
Comments
pellared
changed the title
reyang
added
the
[label deprecated] triaged-accepted
jack-berg
pushed a commit
that referenced
this issue
Mar 15, 2024
Fixes #3841 ## Changes - Update "Instrumentation Scope" term in glossary. - Update "Attribute Collections" (in common definitions) to include instrumentation scope attributes. - Change the instrumentation scope type definition from `(Name,Version) tuple of strings` to Instrumentation Scope definition (as the current definition misses Scheme URL and Attributes). - Refer to `InstrumentationScope` Data Model field in Bridge API to make the spec easier to follow. - Move the part relevant to Bridge API usage from the Data Model. - Remove "Version is optional. Name SHOULD be specified if version is specified, otherwise Name is optional." which should act as recommendation in the API. But the API already contains information how the parameters should be used. --------- Co-authored-by: Reiley Yang <[email protected]> Co-authored-by: Tigran Najaryan <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this issue
Oct 31, 2024
…3855) Fixes open-telemetry#3841 ## Changes - Update "Instrumentation Scope" term in glossary. - Update "Attribute Collections" (in common definitions) to include instrumentation scope attributes. - Change the instrumentation scope type definition from `(Name,Version) tuple of strings` to Instrumentation Scope definition (as the current definition misses Scheme URL and Attributes). - Refer to `InstrumentationScope` Data Model field in Bridge API to make the spec easier to follow. - Move the part relevant to Bridge API usage from the Data Model. - Remove "Version is optional. Name SHOULD be specified if version is specified, otherwise Name is optional." which should act as recommendation in the API. But the API already contains information how the parameters should be used. --------- Co-authored-by: Reiley Yang <[email protected]> Co-authored-by: Tigran Najaryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/bridge-api.md#get-a-logger:
Attributes of what type are these? Log attributes or common attributes? My guess is that these are "common attributes" but should be clearly defined by the specification.
What the implementation should with the provided attributes? Shouldn't the data model for instrumentation scope be updated to also contain the attributes? See OTLP defintion and glossary definition. I think it is a bug in the specification.
Related PR: open-telemetry/opentelemetry-go#4809
The text was updated successfully, but these errors were encountered: