Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve semantic inconsistencies for non traditional messaging #1027

Merged
merged 16 commits into from
Oct 21, 2020
Merged

Resolve semantic inconsistencies for non traditional messaging #1027

merged 16 commits into from
Oct 21, 2020

Commits on Sep 29, 2020

  1. Resolve semantic inconsistencies for non traditional messaging 

    Fixes open-telemetry#977
    @kenfinnigan
    kenfinnigan committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    d7ced57 View commit details
    Browse the repository at this point in the history

  2. Fix table

    @kenfinnigan
    kenfinnigan committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    c4b7094 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. - Add new attribute to messaging yaml 

    - Revert changes to existing examples but change them to use RabbitMQ instead of Kafka
- Add specific Kafka example with new attributes
    @kenfinnigan
    kenfinnigan committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    697ce0a View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Update ToC, remove messaging.service, add information about `peer.s… 

    …ervice` and `service.name` for Apache Kafka
    @kenfinnigan
    kenfinnigan committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    362e0c1 View commit details
    Browse the repository at this point in the history

  2. Fix trailing space

    @kenfinnigan
    kenfinnigan committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    f981ac0 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. - Update messaging.yaml to align with document 

    - Minor update to wording of Apacha Kafka service and peer names for Producers and Consumers
    @kenfinnigan
    kenfinnigan committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    a7272ce View commit details
    Browse the repository at this point in the history

  2. Fix "ref" positioning

    @kenfinnigan
    kenfinnigan committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    9304911 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Updated from running make table-generation

    @kenfinnigan
    kenfinnigan committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    aa657fe View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Updates to service.name and peer.service meaning for producers and co… 

    …nsumers.

Also fixed some references to message.service that lingered
    @kenfinnigan
    kenfinnigan committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    2f442b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Updates based on feedback

    @kenfinnigan
    kenfinnigan committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    497f8dc View commit details
    Browse the repository at this point in the history

  2. Fix generated table

    @kenfinnigan
    kenfinnigan committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    d1143e8 View commit details
    Browse the repository at this point in the history

  3. Update semantic_conventions/trace/messaging.yaml 

    Co-authored-by: Christian Neumüller <[email protected]>
    @kenfinnigan @Oberon00
    kenfinnigan and Oberon00 authored Oct 9, 2020
    Configuration menu
    Copy the full SHA
    ac664f6 View commit details
    Browse the repository at this point in the history

  4. Fix generation

    @kenfinnigan
    kenfinnigan committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    a3d183b View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Adjust description of topic, as there may be no subscribers when a me… 

    …ssage is added to a topic
    @kenfinnigan
    kenfinnigan committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    fc461bc View commit details
    Browse the repository at this point in the history

  2. Forgot to regenerate tables

    @kenfinnigan
    kenfinnigan committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    1baeb11 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Add "tombstone" to Kafka section as instrumentation currently uses it

    @kenfinnigan
    kenfinnigan committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    46b1bda View commit details
    Browse the repository at this point in the history