Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Shutdown() method to *Provider SDK #1074

Merged
merged 5 commits into from
Oct 14, 2020
Merged

Add a Shutdown() method to *Provider SDK #1074

merged 5 commits into from
Oct 14, 2020

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Oct 8, 2020

Resolve #1073

@XSAM XSAM requested review from a team October 8, 2020 10:44
tigrannajaryan
tigrannajaryan reviewed Oct 8, 2020
View reviewed changes
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/trace/api.md Outdated Show resolved Hide resolved
specification/trace/api.md Outdated Show resolved Hide resolved
Oberon00
Oberon00 reviewed Oct 9, 2020
View reviewed changes
Copy link
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I'm definitely in favor of adding Shutdown

specification/trace/api.md Outdated Show resolved Hide resolved
specification/trace/sdk.md Show resolved Hide resolved
specification/trace/sdk.md Outdated Show resolved Hide resolved
specification/trace/sdk.md Outdated Show resolved Hide resolved
specification/trace/sdk.md Outdated Show resolved Hide resolved
specification/trace/sdk.md Outdated Show resolved Hide resolved
@arminru
Copy link
Member

arminru commented Oct 9, 2020

@XSAM Please add the respective entries in CHANGELOG.md and spec-compliance-matrix.md. Thanks!

@XSAM XSAM changed the title Add a Shutdown() method to *Provider Add a Shutdown() method to *Provider SDK Oct 13, 2020
Oberon00
Oberon00 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Oberon00 Oberon00 added area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory labels Oct 13, 2020
@bogdandrutu bogdandrutu merged commit c115d08 into open-telemetry:master Oct 14, 2020
@XSAM XSAM deleted the shutdown-provider branch October 14, 2020 15:40
@fbogsany fbogsany mentioned this pull request Oct 27, 2020
Closed
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@XSAM
Add a Shutdown() method to *Provider SDK (open-telemetry#1074)
2e362c7 
* Add a Shutdown() method to `*Provider`

* Add more precise description

* Update description of shutting down a provider

* Update CHANGELOG & spec-compliance-matrix

* Remove Shutdown function from API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan left review comments

@arminru arminru arminru approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@Oberon00 Oberon00 Oberon00 approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Shutdown() method to *Provider
6 participants
@XSAM @arminru @carlosalberto @Oberon00 @bogdandrutu @tigrannajaryan