Add metric name pluralization guidelines #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfoote
force-pushed
the
metric_naming_guidance
branch
from
940e513
to
0a3f19a
Compare
This was referenced Oct 20, 2020
arminru
reviewed
Oct 20, 2020
There was a problem hiding this comment.
While you're at it, it would be nice if you could add a TOC on top (like on your other PR https://github.com/open-telemetry/opentelemetry-specification/pull/1076/files#r502371390) since the document is already getting quite long. Thanks!
arminru
reviewed
Oct 20, 2020
justinfoote
force-pushed
the
metric_naming_guidance
branch
from
c8970ab
to
5c5c271
Compare
jmacd
approved these changes
Oct 27, 2020
MrAlias
approved these changes
Nov 6, 2020
|
I've just added one small correction. It turns out, I was mis-using the term pseudo-unit. The things we have in curly braces in the units spec are non-units. |
arminru
approved these changes
Nov 9, 2020
jmacd
approved these changes
Nov 10, 2020
|
(I'm trying to merge this: @justinfoote surely you've signed the CLA-- not sure what else I can do.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the solution to issue #600.
Changes
This PR is a clarification in the general metrics semantic conventions guidelines. It adds some guidelines about when to use a pluralized metric name (like
system.paging.faults) and when to use a singular name (likehttp.server.duration).Related issues #600 and #705
Related oteps: #108