Add none for exporter selection enums. #1439
Conversation
| @@ -141,11 +141,13 @@ Known values for OTEL_TRACES_EXPORTER are: | |||
| - `"otlp"`: [OTLP](./protocol/otlp.md) | |||
| - `"jaeger"`: [Jaeger gRPC](https://www.jaegertracing.io/docs/1.21/apis/#protobuf-via-grpc-stable) | |||
| - `"zipkin"`: [Zipkin](https://zipkin.io/zipkin-api/) (Defaults to [protobuf](https://github.com/openzipkin/zipkin-api/blob/master/zipkin.proto) format) | |||
| - `"none"`: Disables export of traces. | |||
There was a problem hiding this comment.
Nit: No sure about "disable". If the application adds its own exporter, it probably won't get disabled by this setting.
There was a problem hiding this comment.
Thanks tried tweaking
carlosalberto
added
area:sdk
There was a problem hiding this comment.
What is the scenario that we want people to "disable" trace but still link all the trace SDK?
We use this in the javaagent, so that vendors can disable the OTLP exporter and provide their own exporter, while still getting all of the other auto-configuration goodness.
|
@bogdandrutu Yeah this is for the case we provide a batteries included package like the Java agent. Another case is wanting to only export traces without metrics. |
Co-authored-by: Armin Ruech <[email protected]>
|
@anuraaga @trask thanks for the explanation. Next time please describe this in the PR description or an issue, it is important to make sure that we have good reasons (documented) for what we change/add :) Every API/property we add will add support cost so we need to understand why we are paying this cost :) |
Changes
Adds
noneas an option for exporter selection. Because the default isotlp, there is no way to disable signal export via env vars.