-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rabbitmq to semantic conventions yaml #1651
Conversation
I think the
|
Good catch, thank you! Please make sure to reference this new group in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/messaging.md#rabbitmq and run the markdown generator as documented here: https://github.com/open-telemetry/opentelemetry-specification/tree/main/semantic_conventions. |
Indeed. I re-ran the job and now it's passing. Apparently Chocolatey was down before. |
Done. Thank you for the review and for pointing me to the relevant documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add an entry in CHANGELOG.md that this already specified key is now also defined in the respective YAML file.
done |
this PR is uncontroversial as it only changes from text to yaml, not the semantic. And got a lot of approvals fast. Merging |
* add rabbitmq to semantic conventions yaml * add example for rabbitmq routing key * messaging.rabbitmq - use required syntax * messaging.rabbitmq generate markdown table from yaml * update changelog with adding rabbitmq to yaml Co-authored-by: Bogdan Drutu <[email protected]>
In trace semantic conventions markdown there is a section about rabbitmq with attribute
messaging.rabbitmq.routing_key
.This attribute is not reflected in the
messaging.yaml
file here.opentelemetry-js auto-generate the attributes from this yaml, thus it is currently missing