Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details to Histogram API #1657

Merged
merged 4 commits into from
May 5, 2021
Merged

Conversation

reyang
Copy link
Member

@reyang reyang commented Apr 27, 2021

Follow up #1617.

Changes

Added details to the Histogram instrument. In #1617 these were left as TODO.

@reyang reyang requested review from a team April 27, 2021 21:45
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
(left few comments about typos)

@jmacd jmacd merged commit 318745a into open-telemetry:main May 5, 2021
@reyang reyang deleted the reyang/histogram branch October 4, 2021 17:33
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* add details to Histogram API

* address review comments

* update example

Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants