-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework FaaS semantic conventions. #1781
Rework FaaS semantic conventions. #1781
Conversation
Depending on the cloud provider, use: | ||
|
||
* **AWS Lambda:** The function [ARN](https://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html). | ||
Take care not to use the "invoked ARN" directly but replace any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if this is possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string replacement or that "the same runtime instance may be invokable with multiple different aliases"? Yes, I verified both. You can easily produce that scenario with the Lambda console UI by creating two different aliases for $LATEST
and then you can test both and you will see that the logs end up in the same logstream without restart.
You can even test it without creating an extra alias. E.g. using aws lambda invoke --function-name 'arn:aws:lambda:us-east-1:12345:function:myfunction:$LATEST
will end up with a different invoked ARN than just aws lambda invoke --function-name 'arn:aws:lambda:us-east-1:12345:function:myfunction
, but the same invoked version & log stream.
@mateuszrzeszutek Please review whenever you have cycles ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@Oberon00 Please update your branch so we can merge this 👍 |
Fixes #1280 (through introduction of aws.lambda.invoked_arn span attribute, @mateuszrzeszutek please check if that is OK).
Addresses #1778.
Changes
aws.lambda.invoked_arn
and clarify that alias must be stripped fromfaas.id
resource attribute for AWS Lambda.CC @skonto