Exempt resources from attribute limits #1892
Conversation
owais
force-pushed
the
exempt-resource-from-limits
branch
from
cb50353
to
0b93524
Compare
owais
force-pushed
the
exempt-resource-from-limits
branch
from
0b93524
to
f560401
Compare
There was a problem hiding this comment.
From the metric perspective, resource attributes also need to be exempt from limits because they are part of the metric stream identity https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/datamodel.md#opentelemetry-protocol-data-model
owais
force-pushed
the
exempt-resource-from-limits
branch
from
f560401
to
44b38e5
Compare
|
Ping @iNikem @open-telemetry/specs-metrics-approvers |
|
Related issue for metrics: #1782 |
|
Spec modification as proposed by this PR nicely described why resource attributes CAN be excluded from attribute limits. But it does not explain why they SHOULD or why do we want to have such an exception. PR description has some justification:
Are current attribute limits specific/scoped into |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Oberon00
added
area:sdk
owais
force-pushed
the
exempt-resource-from-limits
branch
from
44b38e5
to
8a2aee6
Compare
@iNikem Yes, I can confirm at least Java, Python, Go and Node/JS do this. |
Resources are not susceptible to scenarios where excessive attributes can be recorded unlike Spans. Resources are also immutable and it can be hard for some SDKs to apply the limits at source at the time the attributes are added to a resource. Furthermore, limits and Resources both are generally defined and passed on to a TracerProvider which forces a TracerProvider to either mutate the resource or generate a new one with duplicate attributes in order to apply the limits to it.
owais
force-pushed
the
exempt-resource-from-limits
branch
from
8a2aee6
to
998ba83
Compare
|
@iNikem added. |
|
Ping @jsuereth |
|
Reviewers, please respond to unresolved comments. If you want to block merging then request changes, otherwise I am going to merge this since it has the required number of approvals. |
|
No further comments, merging. |
Resources are not susceptible to scenarios where excessive attributes can be recorded unlike Spans. Resources are also immutable and it can be hard for some SDKs to apply the limits at source at the time the attributes are added to a resource. Furthermore, limits and Resources both are generally defined and passed on to a TracerProvider which forces a TracerProvider to either mutate the resource or generate a new one with duplicate attributes in order to apply the limits to it. Co-authored-by: Tigran Najaryan <[email protected]>
Resources are not susceptible to scenarios where excessive attributes
can be recorded unlike Spans. Resources are also immutable and it can be
hard for some SDKs to apply the limits at source at the time the
attributes are added to a resource. Also Limits and Resources
both are generally defined and passed on to a TracerProvider which
forces a TracerProvider to either mutate the resource or generate a new
one with duplicate attributes in order to apply the limits to it.
I propose we explicitly exempt Resources from attribute limits.
Changes
Exempt Resources from attribute limits.