-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify default for OTLP endpoint should, not must, be https #1997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, to avoid breaking a stable SDK release.
@open-telemetry/specs-approvers please review. |
Is it actually a good thing to have the default scheme be To get this working, you'd have to configure TLS for the otlp receiver, issuing and specifying the certificate, and passing the same certificate to app via FYI, here's the original PR where the default scheme was set to |
After more digging, I found this PR that seems to have been the seed for the original I can't find any context in that PR related to why to default to secure. |
@jack-berg Also we don't want to break this invariant for users, as mentioned @anuraaga :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responding to @jack-berg's comments, I think it's a valid concern. However, I think instead we should try to define some kind of "local-lookup" mechanism in a future version of the specification where an SDK can find a local collector and communicate over a locally-optimal protocol. If you're interested in defining/refining that mechanism, would be happy to brainstorm ideas with you.
This has enough approvals. Going to leave open for 1 more business day for feedback before enabling auto-merge. |
Fixes #1984
Changes
Adds a subnote clarifying that while the OTLP endpoint variables should default to https, it is not a must
I mostly copied the wording from #1969