Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system metrics clarification around containers #2388

Closed
wants to merge 2 commits into from
Closed

Add system metrics clarification around containers #2388

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
900e9c9
Add system metrics clarification around containers
trask Feb 28, 2022
357c94d
Update specification/metrics/semantic_conventions/system-metrics.md
trask Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions specification/metrics/semantic_conventions/system-metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ metrics in OpenTelemetry. Consider the [general metric semantic
conventions](README.md#general-metric-semantic-conventions) when creating
instruments not explicitly defined in the specification.

When reporting `system.*` metrics from inside a container, they SHOULD be
container metrics and not host metrics, unless the resource attributes
trask marked this conversation as resolved.
Show resolved Hide resolved
specifically describe the host.

<!-- Re-generate TOC with `markdown-toc --no-first-h1 -i` -->

<!-- toc -->
Expand Down