Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net.host.name and net.host.ip to rpc server #2447

Merged
merged 4 commits into from
Apr 2, 2022

Conversation

trask
Copy link
Member

@trask trask commented Mar 25, 2022

Part of #2214

Changes

Adds net.host.name and net.host.ip to rpc server span attributes.

@trask trask force-pushed the add-net-host-to-rpc-server branch from 71fa8b8 to ec03f07 Compare March 25, 2022 19:10
@trask trask marked this pull request as ready for review March 25, 2022 21:43
@trask trask requested review from a team March 25, 2022 21:43
@arminru arminru added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory and removed spec:metrics Related to the specification/metrics directory labels Mar 28, 2022
semantic_conventions/trace/rpc.yaml Outdated Show resolved Hide resolved
@reyang reyang merged commit 9c02c80 into open-telemetry:main Apr 2, 2022
@trask trask deleted the add-net-host-to-rpc-server branch April 2, 2022 18:44
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants