Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining Kafka and Kafka consumer metrics. #2536

Merged
merged 14 commits into from
May 26, 2022
Merged

Add remaining Kafka and Kafka consumer metrics. #2536

merged 14 commits into from
May 26, 2022

Conversation

carlosalberto
Copy link
Contributor

@carlosalberto carlosalberto commented May 12, 2022 •
edited
Loading

Follow up from #2485 - this time adding the Kafka & Kafka consumer metrics from Kafka Metrics Receiver

I'd like to suggest a few changes:

  • consumer_group in the name is changed to consumer (to match the producer metrics format).
  • General metrics:
    • .brokers becomes UpDownCounter
    • .topic.partitions becomes UpDownCounter
    • .replicas becomes .replicas.all and UpDownCounter
    • .replicas_in_sync becomes .replicas.in-sync and UpDownCounter
  • Consumer metrics:
    • .members becomes UpDownCounter

cc @mwear @jmacd

@carlosalberto carlosalberto requested review from a team May 12, 2022 17:24
reyang
reyang approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory labels May 13, 2022
@carlosalberto
Copy link
Contributor Author

@mwear @reyang Any opinion on the proposed changes in the PR description, and not yet applied? ;)

@reyang
Copy link
Member

reyang commented May 17, 2022

@mwear @reyang Any opinion on the proposed changes in the PR description, and not yet applied? ;)

The proposed changes from PR description look reasonable to me 👍

@carlosalberto
Copy link
Contributor Author

Ping @dmitryax as original author/maintainer of the Kafka Metrics receiver.

@carlosalberto
Copy link
Contributor Author

Ping @dmitryax ;)

@reyang reyang merged commit 58acb09 into open-telemetry:main May 26, 2022
beeme1mr pushed a commit to beeme1mr/opentelemetry-specification that referenced this pull request Aug 31, 2022
@carlosalberto @beeme1mr
Add remaining Kafka and Kafka consumer metrics. (open-telemetry#2536)
6431255
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@carlosalberto
Add remaining Kafka and Kafka consumer metrics. (open-telemetry#2536)
80eb6b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@jmacd jmacd jmacd approved these changes

@mwear mwear mwear approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlosalberto @reyang @mwear @jmacd @bogdandrutu