Fix examples and the link in experimental JSON file format #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tigrannajaryan
commented
Oct 17, 2022
tigrannajaryan
commented
- The severityNumber field is an enum and must use a numeric value according this: Prohibit usage of enum value name strings in OTLP/JSON #2758
- Link to a more appropriate section of otlp.md doc.
reyang
approved these changes
Oct 17, 2022
carlosalberto
approved these changes
Oct 24, 2022
bogdandrutu
approved these changes
Oct 25, 2022
jack-berg
approved these changes
Oct 25, 2022
|
Good to go @tigrannajaryan but we need a rebase ;) |
|
@tigrannajaryan please rebase |
bogdandrutu
reviewed
Nov 1, 2022
tigrannajaryan
force-pushed
the
feature/tigran/fix-json-file
branch
from
2124d24
to
f2d03d2
Compare
- The severityNumber field is an enum and must use a numeric value according this: open-telemetry#2758 - Link to a more appropriate section of otlp.md doc.
- Remove deprecatedCode - Use numeric value for status code
tigrannajaryan
force-pushed
the
feature/tigran/fix-json-file
branch
from
1eefa48
to
d9ca31b
Compare
Done. |
lmolkova
pushed a commit
to lmolkova/opentelemetry-specification
that referenced
this pull request
Nov 3, 2022
…metry#2886) - The severityNumber field is an enum and must use a numeric value according this: open-telemetry#2758 - Link to a more appropriate section of otlp.md doc. - Remove deprecatedCode - Use numeric value for status code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.