Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor grammar changes, addressed feedback from @haf #289

Merged
merged 13 commits into from
Oct 10, 2019

Conversation

SergeyKanzhelev
Copy link
Member

Addressed feedback from #283. Sentences structure, no semantics change.

Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, I thought a PR named "minor grammar changes" was a good place to leave a bunch of minor grammar nit comments.

specification/overview.md Outdated Show resolved Hide resolved
specification/overview.md Outdated Show resolved Hide resolved
specification/overview.md Outdated Show resolved Hide resolved
specification/overview.md Outdated Show resolved Hide resolved
specification/overview.md Outdated Show resolved Hide resolved
specification/overview.md Outdated Show resolved Hide resolved
specification/overview.md Outdated Show resolved Hide resolved
specification/overview.md Outdated Show resolved Hide resolved
@SergeyKanzhelev SergeyKanzhelev merged commit 8746aca into open-telemetry:master Oct 10, 2019
@SergeyKanzhelev SergeyKanzhelev deleted the addressFeedback branch October 10, 2019 20:22
SergeyKanzhelev added a commit to SergeyKanzhelev/opentelemetry-specification that referenced this pull request Feb 18, 2020
* addressed feedback from @haf

* Update specification/overview.md

Co-Authored-By: Chris Kleinknecht <[email protected]>

* Update specification/overview.md

Co-Authored-By: Chris Kleinknecht <[email protected]>

* Update specification/overview.md

Co-Authored-By: Chris Kleinknecht <[email protected]>

* Update specification/overview.md

Co-Authored-By: Chris Kleinknecht <[email protected]>

* Update specification/overview.md

Co-Authored-By: Chris Kleinknecht <[email protected]>

* Update specification/overview.md

Co-Authored-By: Chris Kleinknecht <[email protected]>

* Update specification/overview.md

Co-Authored-By: Chris Kleinknecht <[email protected]>

* Update specification/overview.md

Co-Authored-By: Chris Kleinknecht <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants