Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric for jvm memory usage after gc #2901

Merged
merged 7 commits into from
Nov 8, 2022
Merged

Add metric for jvm memory usage after gc #2901

merged 7 commits into from
Nov 8, 2022

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Oct 24, 2022 •
edited
Loading

Resolves #2900.

Add new metric process.runtime.jvm.memory.usage_after_last_gc.

@jack-berg jack-berg requested review from a team October 24, 2022 18:56
@jack-berg
Copy link
Member Author

cc @open-telemetry/java-instrumentation-maintainers @open-telemetry/java-maintainers

trask
trask approved these changes Oct 31, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jack-berg @trask
Update CHANGELOG.md
b92a3a6 
Co-authored-by: Trask Stalnaker <[email protected]>
breedx-splk
breedx-splk reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@breedx-splk breedx-splk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to drag this out. Do you think we can get away with spelling it process.runtime.jvm.memory.usage_after_gc maybe (last seemed redundant/given)? What about adding an optional attribute for the gc id?

@trask
Copy link
Member

trask commented Nov 3, 2022 •
edited
Loading

Sorry to drag this out. Do you think we can get away with spelling it process.runtime.jvm.memory.usage_after_gc maybe (last seemed redundant/given)?

(guilty) see #2901 (comment)

memory_after_gc seemed ambiguous to me (e.g. is it the sum after each gc during the time period?), but definitely open to revisiting

@breedx-splk
Copy link
Contributor

memory_after_gc seemed ambiguous to me (e.g. is it the sum after each gc during the time period?), but definitely open to revisiting

Hah! Ok, let's stay the course. 🙊

@reyang reyang merged commit 374c34c into open-telemetry:main Nov 8, 2022
@jack-berg jack-berg mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breedx-splk breedx-splk breedx-splk left review comments

@trask trask trask approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@reyang reyang reyang approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees

@carlosalberto carlosalberto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track JVM memory usage after GC
6 participants
@jack-berg @trask @breedx-splk @carlosalberto @reyang @mateuszrzeszutek