Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClickHouse in the database group #3011

Merged
merged 4 commits into from
Jan 4, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ release.
([#2982](https://github.com/open-telemetry/opentelemetry-specification/pull/2982))
- Update hardware metrics to use `direction` as per general semantic conventions
([#2942](https://github.com/open-telemetry/opentelemetry-specification/pull/2942))
- Add ClickHouse to db.system semantic conventions
([#3011](https://github.com/open-telemetry/opentelemetry-specification/pull/3011))

### Compatibility

Expand Down
3 changes: 3 additions & 0 deletions semantic_conventions/trace/database.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ groups:
- id: opensearch
value: 'opensearch'
brief: 'OpenSearch'
- id: clickhouse
value: 'clickhouse'
brief: 'ClickHouse'
- id: connection_string
tag: connection-level
type: string
Expand Down
1 change: 1 addition & 0 deletions specification/trace/semantic_conventions/database.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ Some database systems may allow a connection to switch to a different `db.user`,
| `memcached` | Memcached |
| `cockroachdb` | CockroachDB |
| `opensearch` | OpenSearch |
| `clickhouse` | ClickHouse |
<!-- endsemconv -->

### Notes and well-known identifiers for `db.system`
Expand Down