Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize specification related to OTLP file exporter #3031

Merged

Conversation

alanwest
Copy link
Member

Fixes #3003
Contributes to #2911

Changes

This PR moves and reorganizes parts of the specification relevant to exporting OTLP data to a file.

  • Removes the "Build-in exporters" section from the Log SDK. The OTLP exporter has its own specification covering all signals. The part regarding a file exporter is not unique to logs. Exporting OTLP data to a file is also applicable to trace and metric data.
  • Moves the file describing OTLP JSON serialization under the protocol subdirectory. As discussed in the Logs SIG (12/7/2022), this file provides a foundation for further progress on specifying an OTLP file exporter.

@alanwest alanwest requested review from a team December 13, 2022 21:51
@alanwest alanwest changed the title Alanwest/otlp file exporter reorg Reorganize specification related to OTLP file exporter Dec 13, 2022
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Java already has exporters that log in OTLP JSON format (e.g. OtlpJsonLoggingSpanExporter).

specification/logs/sdk.md Show resolved Hide resolved
@arminru arminru added spec:logs Related to the specification/logs directory area:sdk Related to the SDK labels Dec 19, 2022
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@tigrannajaryan tigrannajaryan merged commit 56c20c2 into open-telemetry:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:logs Related to the specification/logs directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Built-in exporters" section in Log SDK
6 participants