Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloud spanner and mssql compact to db specifications #3105

Merged
merged 6 commits into from
Jan 23, 2023
Merged

Add cloud spanner and mssql compact to db specifications #3105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
776cdd9
Add Cloud Spanner
mrblonde91 Jan 16, 2023
dced025
Add mssql compact
mrblonde91 Jan 16, 2023
5cc771d
Merge branch 'main' into feature/addadditionaldbs
mrblonde91 Jan 18, 2023
dbf0979
Relocate mssql compact
mrblonde91 Jan 18, 2023
24e2e0c
Merge branch 'main' into feature/addadditionaldbs
mrblonde91 Jan 23, 2023
9af3b88
Merge branch 'main' into feature/addadditionaldbs
carlosalberto Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ release.

## v1.17.0 (2023-01-17)

- Add Cloud Spanner and Microsoft SQL Server Compact to db.system semantic conventions.
[#3105](https://github.com/open-telemetry/opentelemetry-specification/pull/3105)

### Context

- No changes.
Expand Down
6 changes: 6 additions & 0 deletions semantic_conventions/trace/database.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ groups:
- id: mssql
value: 'mssql'
brief: 'Microsoft SQL Server'
- id: mssqlcompact
value: 'mssqlcompact'
brief: 'Microsoft SQL Server Compact'
- id: mysql
value: 'mysql'
brief: 'MySQL'
Expand Down Expand Up @@ -160,6 +163,9 @@ groups:
- id: clickhouse
value: 'clickhouse'
brief: 'ClickHouse'
- id: spanner
value: 'spanner'
brief: 'Cloud Spanner'
- id: connection_string
tag: connection-level
type: string
Expand Down
2 changes: 2 additions & 0 deletions specification/trace/semantic_conventions/database.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ Some database systems may allow a connection to switch to a different `db.user`,
|---|---|
| `other_sql` | Some other SQL database. Fallback only. See notes. |
| `mssql` | Microsoft SQL Server |
| `mssqlcompact` | Microsoft SQL Server Compact |
| `mysql` | MySQL |
| `oracle` | Oracle Database |
| `db2` | IBM Db2 |
Expand Down Expand Up @@ -117,6 +118,7 @@ Some database systems may allow a connection to switch to a different `db.user`,
| `cockroachdb` | CockroachDB |
| `opensearch` | OpenSearch |
| `clickhouse` | ClickHouse |
| `spanner` | Cloud Spanner |
<!-- endsemconv -->

### Notes and well-known identifiers for `db.system`
Expand Down