BREAKING: Change span statuses for gRPC server spans #3333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
MrAlias
reviewed
Mar 22, 2023
pellared
requested review from
tigrannajaryan and
MrAlias
and removed request for
tigrannajaryan and
MrAlias
tigrannajaryan
approved these changes
Mar 22, 2023
pellared
requested review from
tigrannajaryan,
trask and
carlosalberto
and removed request for
tigrannajaryan and
trask
tigrannajaryan
approved these changes
Mar 30, 2023
MrAlias
approved these changes
Mar 30, 2023
trask
approved these changes
Mar 31, 2023
carlosalberto
approved these changes
Mar 31, 2023
reyang
approved these changes
Mar 31, 2023
jack-berg
approved these changes
Mar 31, 2023
|
@tigrannajaryan Any opinion on getting this merged for the upcoming April Release? |
I think we can merge. |
|
@pellared can you resolve the conflicts? |
|
@tigrannajaryan @carlosalberto Done. The PR is ready to be merged 😉 |
This was referenced Jul 6, 2023
Merged
6 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…3333) Fixes open-telemetry#3110 ## Changes The idea behind the PR is to make the spam statuses gRPC convention similar to HTTP semantic conventions. The gRPC statuses -> HTTP status codes mapping is not anywhere strictly defined. However, there is are some approximations which can be found: - grpc/grpc@bb04e07#diff-c94ff143c8f378e6925a985fa18528a8254a6d7fc34bc855e1de13f1e7f3e464 - https://github.com/googleapis/googleapis/blob/master/google/rpc/code.proto I got confused if we should treat `INTERNAL` as `Error` for `SpanKind.SERVER` because of: - https://github.com/grpc/grpc/blob/master/doc/http-grpc-status-mapping.md - https://github.com/grpc/grpc-go/blob/a02aae6168aa683a1f106e285ec10eb6bc1f6ded/internal/transport/handler_server.go#L90C8-L92 - https://github.com/grpc/grpc-go/blob/a02aae6168aa683a1f106e285ec10eb6bc1f6ded/internal/transport/http_util.go#L73 On the other hand, [the description](https://github.com/grpc/grpc/blob/master/doc/statuscodes.md) of `INTERNAL` says: > Internal errors. This means that some invariants expected by the underlying system have been broken. This error code is reserved for serious errors. Therefore, I decided to leave it as `Error`. Also because this is backwards compatible (at least for this gRPC status). --------- Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3110
Changes
The idea behind the PR is to make the spam statuses gRPC convention similar to HTTP semantic conventions.
The gRPC statuses -> HTTP status codes mapping is not anywhere strictly defined.
However, there is are some approximations which can be found:
I got confused if we should treat
INTERNALasErrorforSpanKind.SERVERbecause of:On the other hand, the description of
INTERNALsays:Therefore, I decided to leave it as
Error. Also because this is backwards compatible (at least for this gRPC status).