Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

describe JVM CPU metrics #3487

Closed

Conversation

zeitlinger
Copy link
Member

Improve description of jvm cpu metrics - especially the value ranges.

@zeitlinger zeitlinger requested review from a team May 9, 2023 08:25
instrument: gauge
unit: "1"

- id: metric.process.runtime.jvm.system.cpu.load_1m
type: metric
metric_name: process.runtime.jvm.system.cpu.load_1m
brief: "Average CPU load of the whole system for the last minute."
note: >
The value range is [0,n], where n is the number of CPU cores.
Copy link
Member

@joaopgrassi joaopgrassi May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, did I get it wrong or the link provided means something else? I couldn't find any mention of CPU cores there. It says

is the sum of the number of runnable entities queued to the available processors and the number of runnable entities running on the available processors averaged over a period of time

Also, the link says when load average is not available, it should return a negative number, which contradicts with the value range added here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the part about negative values, but I still think "CPU cores" is equivalent to the longer explanation in the link. Can you elaborate when/how it could be different?

@joaopgrassi
Copy link
Member

There's also this PR that renames some of these metrics, maybe that also impacts things here? #3472

@reyang
Copy link
Member

reyang commented May 9, 2023

@zeitlinger heads up - I'm closing this PR since semantic conventions are being removed from this repo (opentelemetry-specification), we'll ask you to resubmit the PR in a new repo, please refer to #3474 (comment).

@reyang reyang closed this May 9, 2023
@reyang reyang added the area:semantic-conventions Related to semantic conventions label May 9, 2023
@zeitlinger zeitlinger deleted the jvm_cpu_description branch May 12, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants