Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exemplar default language normative #4009

Merged

Conversation

alanwest
Copy link
Member

I'm making my best guess of what was intended. If the language should use SHOULD or MAY please comment.

@alanwest alanwest requested review from a team April 23, 2024 23:40
@reyang
Copy link
Member

reyang commented Apr 23, 2024

If the language should use SHOULD or MAY please comment.

+1 on SHOULD.

@reyang reyang added the spec:metrics Related to the specification/metrics directory label Apr 24, 2024
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD is reasonable here.

@yurishkuro yurishkuro merged commit 8c61382 into open-telemetry:main Apr 24, 2024
7 checks passed
@alanwest alanwest deleted the alanwest/normative-exemplar-defaults branch April 24, 2024 15:39
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
I'm making my best guess of what was intended. If the language should
use `SHOULD` or `MAY` please comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants