Remove component attribute from semantic conventions
#447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
Oberon00
approved these changes
Feb 7, 2020
| @@ -13,7 +13,6 @@ attribute names. | |||
|
|
|||
| | Attribute name | Notes and examples | Required? | | |||
| | :------------- | :----------------------------------------------------------- | --------- | | |||
| | `component` | Database driver name or database name (when known) `"JDBI"`, `"jdbc"`, `"odbc"`, `"postgreSQL"`. | Yes | | |||
bogdandrutu
approved these changes
Feb 10, 2020
jmacd
approved these changes
Feb 10, 2020
carlosalberto
approved these changes
Feb 10, 2020
tigrannajaryan
approved these changes
Feb 11, 2020
|
I think we are ready to merge this one, but @arminru might need to do some merging locally first (there's no option to resolve conflicts using the github UI). |
|
@carlosalberto done! (although I did press the Update branch button on GH 😉) |
|
@arminru possibly you created the PR without checking the "allow maintainers to update" option checked? |
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
This was referenced Feb 18, 2020
Merged
mwear
added a commit
to open-telemetry/opentelemetry-ruby
that referenced
this pull request
May 26, 2020
See open-telemetry/opentelemetry-specification#447 Adapters will later be able to specify what instrumentation library they are, and the exporters can then log this however they want: #264 Co-authored-by: Matthew Wear <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #271 it was decided to drop the span attribute
componentfrom the semantic conventions.