Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate favicon.ico and move favicon.png into subdir #1590

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

breedx-splk
Copy link
Contributor

@breedx-splk breedx-splk commented Aug 2, 2022

Hopefully resolves #640.

According to these docs the theme favicons (docsy in our case) can be overwritten by placing them into the static/favicons subdir.

I didn't find any other references to the existing favicon.png so I moved it as well as adding the new favicon.ico.

@breedx-splk breedx-splk requested a review from a team August 2, 2022 23:22
@cartermp
Copy link
Contributor

cartermp commented Aug 2, 2022

Unfortunately this seems to still render the docsy icon in the deploy preview

@breedx-splk
Copy link
Contributor Author

Unfortunately this seems to still render the docsy icon in the deploy preview

Yeah this is interesting. Chrome rendered the old one for me as well, even though the favicon.ico seems to be correct: https://deploy-preview-1590--opentelemetry.netlify.app/favicons/favicon.ico

Let me add the complete set of images and see how that goes.

@breedx-splk
Copy link
Contributor Author

Wow looks to me like that might have worked. 😸

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! It does indeed work.

@chalin
Copy link
Contributor

chalin commented Aug 3, 2022

Coolio! Thanks @breedx-splk. I'm curious: how did you generate the different sizes of the favicon?

@breedx-splk
Copy link
Contributor Author

Coolio! Thanks @breedx-splk. I'm curious: how did you generate the different sizes of the favicon?

Well the Docsy docs say to use https://cthedot.de/icongen/, so I started with our high-res png that was already here and pushed it to icongen and got a zip file. That zip file didn't have every resolution, so I kept the ones that they generated and then used the imagemagick convert command to make the remaining missing sizes.

Make sense?

@chalin
Copy link
Contributor

chalin commented Aug 3, 2022

Yes, thanks for explaining the steps you took @breedx-splk!

@chalin chalin merged commit 25e6a9a into open-telemetry:main Aug 3, 2022
@chalin
Copy link
Contributor

chalin commented Aug 3, 2022

/cc @nate-double-u @thisisobate 👆 ... in case other Docsy-based projects need the same work done 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docsy favicons are being used instead of that of OTel
3 participants