-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate favicon.ico and move favicon.png into subdir #1590
Conversation
Unfortunately this seems to still render the docsy icon in the deploy preview |
Yeah this is interesting. Chrome rendered the old one for me as well, even though the Let me add the complete set of images and see how that goes. |
Wow looks to me like that might have worked. 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! It does indeed work.
Coolio! Thanks @breedx-splk. I'm curious: how did you generate the different sizes of the favicon? |
Well the Docsy docs say to use https://cthedot.de/icongen/, so I started with our high-res png that was already here and pushed it to icongen and got a zip file. That zip file didn't have every resolution, so I kept the ones that they generated and then used the imagemagick Make sense? |
Yes, thanks for explaining the steps you took @breedx-splk! |
/cc @nate-double-u @thisisobate 👆 ... in case other Docsy-based projects need the same work done 😄 |
Hopefully resolves #640.
According to these docs the theme favicons (docsy in our case) can be overwritten by placing them into the
static/favicons
subdir.I didn't find any other references to the existing
favicon.png
so I moved it as well as adding the newfavicon.ico
.