Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Get Started for the Collector and separate install instructions #3412

Conversation

theletterf
Copy link
Member

This solves #1695 and potentially a few others.

I went for the simplest possible approach:

  • Download the binary or Docker image
  • Run with default configuration
  • Install telemetrygen
  • Send traces
  • Check in zpages

At the same time I've split the install instructions into a separate page.

The problem I'm seeing with using telemetrygen is that the official install instructions don't work (open-telemetry/opentelemetry-collector-contrib#27855) and that we don't provide a binary (open-telemetry/opentelemetry-collector-contrib#27856). I think the first issue should be solved, at least.

Note: I'm getting some errors in a blog post that I haven't touched...

@theletterf theletterf requested review from a team and bogdandrutu and removed request for a team October 19, 2023 12:43
@theletterf
Copy link
Member Author

@mx-psi How could I replace the telemetrygen instructions so that they'd work? Getting rid of the Go dependency for the get started would be nice, but I guess that doing it all in docker would require creating a docker network first?

@mx-psi
Copy link
Member

mx-psi commented Oct 19, 2023

@mx-psi How could I replace the telemetrygen instructions so that they'd work? Getting rid of the Go dependency for the get started would be nice, but I guess that doing it all in docker would require creating a docker network first?

I think we should address open-telemetry/opentelemetry-collector-contrib#27855 and fix the go install

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure that your PR does not contain updates to the content-modules.

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to write this down @theletterf! Some change requests and suggestions

content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
@theletterf
Copy link
Member Author

Closing this and opening #3426 due to pesky submodule issues...

@theletterf theletterf closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants