chore: add missing ':'s in registry cSpell ignore lists #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theletterf
approved these changes
Oct 24, 2023
our contribution guidelines are outdated, we had an issue for that in the past (#897, #1890), so yes, all help is appreciated here! |
cartermp
approved these changes
Oct 30, 2023
|
I have not seen |
chalin
force-pushed
the
fix-cspell-in-registry
branch
from
bf7701c
to
08066e1
Compare
chalin
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Catching up on PRs. @simi is right, we don't need a :, ... unless we're encoding the ignore rule as part of the Hugo front-matter. In such cases, we need the colon because cSpell:ignore is being used as a YAML key name.
I'd suggest not making these changes.
Signed-off-by: svrnm <[email protected]>
chalin
force-pushed
the
fix-cspell-in-registry
branch
from
08066e1
to
420442d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not mandatory, but this creates consistency with other
cSpell:ignore:lists we have