Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create instrumentation-go-kafka.yml #5096

Merged
merged 7 commits into from
Aug 25, 2024
Merged

Create instrumentation-go-kafka.yml #5096

merged 7 commits into from
Aug 25, 2024

Conversation

jurabek
Copy link
Contributor

@jurabek jurabek commented Aug 23, 2024

  • Adding confluent-kafka-go instrumentation into registry

@jurabek jurabek requested a review from a team August 23, 2024 22:53
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 23, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

cartermp
cartermp approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cartermp
Copy link
Contributor

/fix:all

@opentelemetrybot

This comment was marked as outdated.

Sign in to view
@opentelemetrybot

This comment was marked as outdated.

Sign in to view
@cartermp
Copy link
Contributor

@jurabek you'll need to move the file two levels up to be under /data/registry, not the nested folders of /data/registry/data/registry

@jurabek
Copy link
Contributor Author

jurabek commented Aug 24, 2024

@jurabek you'll need to move the file two levels up to be under /data/registry, not the nested folders of /data/registry/data/registry

I moved the file to the correct folder. Thank you very much @cartermp 🙏

@cartermp
Copy link
Contributor

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10541771980

@opentelemetrybot
Copy link
Collaborator

fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/10541771980 for details

@theletterf
Copy link
Member

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10545889108

@theletterf theletterf added this pull request to the merge queue Aug 25, 2024
Merged via the queue into open-telemetry:main with commit a570a00 Aug 25, 2024
5 checks passed
@jurabek jurabek deleted the patch-2 branch August 26, 2024 15:05
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
@jurabek @theletterf @opentelemetrybot
Create instrumentation-go-kafka.yml (open-telemetry#5096)
bd4aa08 
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: opentelemetrybot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
registry
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jurabek @cartermp @opentelemetrybot @theletterf