Replace "dynamically injects bytecode" in Python zero-code instrumentation #5130
Conversation
|
/fix:refcache |
|
You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10638770943 |
|
IMPORTANT: (RE-)RUN
|
|
@open-telemetry/python-approvers PTAL! |
|
/fix:refcache |
|
You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10675267603 |
|
fix:refcache failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/10675267603. |
|
/fix:refcache |
|
You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10681135620 |
|
IMPORTANT: (RE-)RUN
|
| @@ -1711,6 +1711,10 @@ | |||
| "StatusCode": 200, | |||
| "LastSeen": "2024-01-18T19:55:51.433612-05:00" | |||
| }, | |||
| "https://docs.pytest.org/en/stable/how-to/monkeypatch.html#monkeypatching-functions": { | |||
There was a problem hiding this comment.
I think this chunk is not needed, looks like fix:refcache only adds entries
There was a problem hiding this comment.
Thanks for the review @xrmx. It means a lot; this is my first contribution to open source.
I was unfamiliar with comment-triggered actions like /fix:refcache. Should only maintainers do this?
I am also reading the contributing process and wonder if there a 'checklist' to clean up my local before committing, e.g. npx prettier --write?
There was a problem hiding this comment.
Hey @CFly17! Thanks for your contribution, happy to read that you choose otel for being your first!
The /fix:* commands are just automations we use run the npm fix:* commands without pulling your PR, running it locally and pusing it back. You may want to run npm fix:all before pushing your PR, but since we sometimes do inline changes, etc. we have no issues with a PR that has failing CI checks. The thing that counts is that those checks are green shortly before merging the PR, and this can either be done by you or by a maintainer.
Note, that this is how we (OTel Docs Maintainer) are doing it, other OSS projects might choose a different approach
…ation (open-telemetry#5130) Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Update/clarify the automatic instrumentation method for Python zero-code instrumentation
opentelemetry-bootstrap -a installcommand uses monkey patching