Skip to content

Commit

Permalink
Move to the correct section.
Browse files Browse the repository at this point in the history
  • Loading branch information
dashpole authored May 6, 2022
1 parent ca96af8 commit 974e21f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions text/0195-kubernetes-resource-detection.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ Kubernetes supports defining environment variables based on [dependent environme

This approach has a few drawbacks:

* `OTEL_RESOURCE_ATTRIBUTES` may need to include additional attibutes other than those used for kubernetes. This makes it harder to apply the same environment variables across all pods.
* `OTEL_RESOURCE_ATTRIBUTES` may need to include additional attibutes other than those used for kubernetes. This makes it harder to apply the same environment variables across all pods. It is also difficult to correctly merge several sets of otel environment variables together: open-telemetry/opentelemetry-specification#1982.
* `OTEL_RESOURCE_ATTRIBUTES` doesn't have a way to specify the schema version it should apply to. This would conflict with the ability of [telemetry schemas](https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md#solution-summary) to convert from older versions of semantic conventions to newer ones.

### Alternative: Support multiple OTEL_RESOURCE_ATTRIBUTES_* variables
Expand Down Expand Up @@ -145,7 +145,6 @@ This approach has a few drawbacks:

* This method doesn't have a way to specify schema version it should apply to. This would conflict with the ability of [telemetry schemas](https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md#solution-summary) to convert from older versions of semantic conventions to newer ones.
* Some resource attributes contain `_` characters. Converting `_` in environment variable names to `.` would not allow such attributes to be set. For example, `CLOUD_AVAILABILITY_ZONE` would be converted to `cloud.availability.zone`, rather than the correct `cloud.availability_zone`.
* It is difficult to correctly merge several sets of otel environment variables together: open-telemetry/opentelemetry-specification#1982.

## Future possibilities

Expand Down

0 comments on commit 974e21f

Please sign in to comment.