Semconv 1.23.1 #36
Merged
Semconv 1.23.1 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
We should delay merging / releasing this until #24 is merged. |
jack-berg
commented
Nov 17, 2023
| @@ -97,6 +97,30 @@ public final class {{class}} { | |||
|
|
|||
| {%- endfor %} | |||
|
|
|||
| {%- if class_name == "MessagingOperationValues" %} | |||
There was a problem hiding this comment.
I don't see any evidence in the template that we've accommodated the removal of values from semantic conventions enums, which manifest as static inner classes. But this seemed like the most correct thing to do. Also, we're using japicmp to ensure we don't make incompatible changes (until we resolve #6) and not fixing this causes japicmp to fail.
mateuszrzeszutek
approved these changes
Nov 20, 2023
|
I've merged #24 and I think we're good to merge this and cut a release of 1.23.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #35.