Update to semantic-conventions 1.26.0 #73
Conversation
| * | ||
| * @deprecated Deprecated, use `messaging.client.id` instead. | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Due to duplicate variable names, CI cannot pass😂.
There was a problem hiding this comment.
you could work around this by adding
{# deprecated messaging.client_id clashes with messaging.client.id #}
{%- if attribute.fqn != "messaging.client_id" %}
to
@lmolkova is there a better solution for this?
There was a problem hiding this comment.
check out open-telemetry/semantic-conventions#1031 and open-telemetry/semantic-conventions#1118
we may want to go ahead and implement option 2 from open-telemetry/semantic-conventions#1118 (but wait to merge it until that proposal is finalized)
I've added topic to today's Java SIG meeting to discuss
There was a problem hiding this comment.
See #75 - we'll provide build-tool fix ASAP as we have a concensus
There was a problem hiding this comment.
Here's the change that drops problematic attribute - crossoverJie#1 (if Java SIG will accept it as a mitigation)
There was a problem hiding this comment.
Here's the change that drops problematic attribute - crossoverJie#1 (if Java SIG will accept it as a mitigation)
Thank you for your work on this issue.
Drop messaging.client_id
Update to semantic-conventions 1.26.0