Skip to content

Commit

Permalink
Editorial: Remove overlooked messaging.source attributes from aws lam…
Browse files Browse the repository at this point in the history
…bda examples (#200)

Co-authored-by: Armin Ruech <[email protected]>
  • Loading branch information
lmolkova and arminru authored Jul 21, 2023
1 parent b9ca87a commit 508bf73
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions docs/faas/aws-lambda.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ See [compatibility](../../supplementary-guidelines/compatibility/aws.md#context-
- [`faas.trigger`][faas] MUST be set to `pubsub`.
- [`messaging.operation`](/docs/messaging/messaging-spans.md) MUST be set to `process`.
- [`messaging.system`](/docs/messaging/messaging-spans.md) MUST be set to `AmazonSQS`.
- [`messaging.destination.kind` or `messaging.source.kind`](/docs/messaging/messaging-spans.md#messaging-attributes) MUST be set to `queue`.

### SQS Message

Expand Down Expand Up @@ -209,15 +208,12 @@ Function F: | Span ProcBatch |
| SpanKind | `PRODUCER` | `PRODUCER` | `CONSUMER` | `CONSUMER` | `CONSUMER` |
| Status | `Ok` | `Ok` | `Ok` | `Ok` | `Ok` |
| `messaging.system` | `AmazonSQS` | `AmazonSQS` | `AmazonSQS` | `AmazonSQS` | `AmazonSQS` |
| `messaging.destination.name` | `Q` | `Q` | | | |
| `messaging.source.name` | | | `Q` | `Q` | `Q` |
| `messaging.destination.kind` | `queue` | `queue` | | | |
| `messaging.source.kind` | | | `queue` | `queue` | `queue` |
| `messaging.destination.name` | `Q` | `Q` | `Q` | `Q` | `Q` |
| `messaging.operation` | | | `process` | `process` | `process` |
| `messaging.message.id` | | | | `"a1"` | `"a2"` |

Note that if Span Prod1 and Span Prod2 were sent to different queues, Span ProcBatch would not have
`messaging.source.name` set as it would correspond to multiple sources.
`messaging.destination.name` set as it would correspond to multiple queues.

The above requires user code change to create `Span Proc1` and `Span Proc2`. In Java, the user would inherit from
[TracingSqsMessageHandler][] instead of Lambda's standard `RequestHandler` to enable them. Otherwise these two spans
Expand Down

0 comments on commit 508bf73

Please sign in to comment.