Skip to content

Commit

Permalink
Remove outdated http.request.header.host guidance
Browse files Browse the repository at this point in the history
  • Loading branch information
trask committed Oct 31, 2023
1 parent 514d737 commit 632151e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ release.
([#459](https://github.com/open-telemetry/semantic-conventions/pull/459))
- Make `client.address` sampling relevant on HTTP server spans.
([#469](https://github.com/open-telemetry/semantic-conventions/pull/469))
- Remove outdated `http.request.header.host` guidance
([#479](https://github.com/open-telemetry/semantic-conventions/pull/479))

### Features

Expand Down
4 changes: 0 additions & 4 deletions docs/http/http-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,6 @@ Following attributes MUST be provided **at span creation time** (when provided a
* [`url.full`](../attributes-registry/url.md)
<!-- endsemconv -->

Note that in some cases host and port identifiers in the `Host` header might be different from the `server.address` and `server.port`, in this case instrumentation MAY populate `Host` header on `http.request.header.host` attribute even if it's not enabled by user.

### HTTP client span duration

There are some minimal constraints that SHOULD be honored:
Expand Down Expand Up @@ -378,8 +376,6 @@ Following attributes MUST be provided **at span creation time** (when provided a

`http.route` MUST be provided at span creation time if and only if it's already available. If it becomes available after span starts, instrumentation MUST populate it anytime before span ends.

Note that in some cases host and port identifiers in the `Host` header might be different from the `server.address` and `server.port`, in this case instrumentation MAY populate `Host` header on `http.request.header.host` attribute even if it's not enabled by user.

## Examples

### HTTP client-server example
Expand Down

0 comments on commit 632151e

Please sign in to comment.