Remove outdated note about not recording HTTP server.address when onl…

…y IP address available
open-telemetry · Oct 16, 2023 · 790bcad · 790bcad
1 parent cee22ec
commit 790bcad
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,8 @@ release.
   ([#401](https://github.com/open-telemetry/semantic-conventions/pull/401))
 - Change `server.port` from recommended to conditionally required on HTTP server semconv.
   ([#399](https://github.com/open-telemetry/semantic-conventions/pull/399))
+- Remove outdated note about not recording HTTP `server.address` when only IP address available.
+  ([#413](https://github.com/open-telemetry/semantic-conventions/pull/413))
 
 ## v1.22.0 (2023-10-12)
 

diff --git a/docs/http/http-metrics.md b/docs/http/http-metrics.md
@@ -133,7 +133,7 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin
   if it's sent in absolute-form.
 - Host identifier of the `Host` header
 
-SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.
+MUST NOT include the port identifier.
 
 **[7]:** Determined by using the first of the following that applies
 
@@ -207,8 +207,6 @@ Tracing instrumentations that do so, MUST also set `http.request.method_original
   if it's sent in absolute-form.
 - Host identifier of the `Host` header
 
-SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.
-
 Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker
 to trigger cardinality limits, degrading the usefulness of the metric.
 
@@ -312,7 +310,7 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin
   if it's sent in absolute-form.
 - Host identifier of the `Host` header
 
-SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.
+MUST NOT include the port identifier.
 
 **[7]:** Determined by using the first of the following that applies
 
@@ -417,7 +415,7 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin
   if it's sent in absolute-form.
 - Host identifier of the `Host` header
 
-SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.
+MUST NOT include the port identifier.
 
 **[7]:** Determined by using the first of the following that applies
 

diff --git a/docs/http/http-spans.md b/docs/http/http-spans.md
@@ -395,7 +395,7 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin
   if it's sent in absolute-form.
 - Host identifier of the `Host` header
 
-SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.
+MUST NOT include the port identifier.
 
 **[5]:** Determined by using the first of the following that applies
 

diff --git a/model/http-common.yaml b/model/http-common.yaml
@@ -83,7 +83,7 @@ groups:
             if it's sent in absolute-form.
           - Host identifier of the `Host` header
 
-          SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.
+          MUST NOT include the port identifier.
 
       - ref: server.port
         brief: >

diff --git a/model/metrics/http.yaml b/model/metrics/http.yaml
@@ -50,8 +50,6 @@ groups:
             if it's sent in absolute-form.
           - Host identifier of the `Host` header
 
-          SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.
-
           Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker
           to trigger cardinality limits, degrading the usefulness of the metric.