Skip to content

Commit

Permalink
Merge branch 'main' into baremetal
Browse files Browse the repository at this point in the history
  • Loading branch information
jsuereth authored Jun 5, 2023
2 parents 56ff35c + 9dc02df commit cb03be4
Show file tree
Hide file tree
Showing 6 changed files with 47 additions and 2 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,9 @@ release.
([#3458](https://github.com/open-telemetry/opentelemetry-specification/pull/3458))
- Specify the value range for JVM CPU metrics.
([#13](https://github.com/open-telemetry/semantic-conventions/pull/13))
- Clarify `process.runtime.jvm.threads.count` refers to platform threads.
([#54](https://github.com/open-telemetry/semantic-conventions/pull/54))
- Add `gcp.gce.instance.name` and `gcp.gce.instance.hostname` resource
attributes for GCP Compute Engine VMs. ([#15](https://github.com/open-telemetry/semantic-conventions/pull/15))
- Add note that HTTP duration metrics should match HTTP span duration.
([#69](https://github.com/open-telemetry/semantic-conventions/pull/69))
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ groups:
- id: metric.process.runtime.jvm.threads.count
type: metric
metric_name: process.runtime.jvm.threads.count
brief: "Number of executing threads."
brief: "Number of executing platform threads."
instrument: updowncounter
unit: "{thread}"
attributes:
Expand Down
22 changes: 22 additions & 0 deletions semantic_conventions/resource/cloud_provider/gcp/gce.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
groups:
- id: gcp.gce
prefix: gcp.gce
type: resource
brief: >
Resources used by Google Compute Engine (GCE).
attributes:
- id: instance.name
type: string
brief: >
The instance name of a GCE instance. This is the value
provided by `host.name`, the visible name of the instance in
the Cloud Console UI, and the prefix for the default
hostname of the instance as defined by the [default internal
DNS
name](https://cloud.google.com/compute/docs/internal-dns#instance-fully-qualified-domain-names).
examples: ['instance-1', 'my-vm-name']
- id: instance.hostname
type: string
brief: >
The hostname of a GCE instance. This is the full value of the default or [custom hostname](https://cloud.google.com/compute/docs/instances/custom-hostname-vm).
examples: ['my-host1234.example.com', 'sample-vm.us-west1-b.c.my-project.internal']
4 changes: 4 additions & 0 deletions specification/metrics/semantic_conventions/http-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ operations. By adding HTTP attributes to metric events it allows for finely tune

This metric is required.

When this metric is reported alongside an HTTP server span, the metric value SHOULD be the same as the HTTP server span duration.

This metric SHOULD be specified with
[`ExplicitBucketBoundaries`](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.21.0/specification/metrics/api.md#instrument-advice)
of `[ 0, 0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10 ]`.
Expand Down Expand Up @@ -241,6 +243,8 @@ SHOULD NOT be set if only IP address is available and capturing name would requi

This metric is required.

When this metric is reported alongside an HTTP client span, the metric value SHOULD be the same as the HTTP client span duration.

This metric SHOULD be specified with
[`ExplicitBucketBoundaries`](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.21.0/specification/metrics/api.md#instrument-advice)
of `[ 0, 0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10 ]`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,12 @@ of `[]` (single bucket histogram capturing count, sum, min, max).
This metric is [recommended][MetricRecommended].
This metric is obtained from [`ThreadMXBean#getDaemonThreadCount()`](https://docs.oracle.com/javase/8/docs/api/java/lang/management/ThreadMXBean.html#getDaemonThreadCount--) and
[`ThreadMXBean#getThreadCount()`](https://docs.oracle.com/javase/8/docs/api/java/lang/management/ThreadMXBean.html#getThreadCount--).
Note that this is the number of platform threads (as opposed to virtual threads).

<!-- semconv metric.process.runtime.jvm.threads.count(metric_table) -->
| Name | Instrument Type | Unit (UCUM) | Description |
| -------- | --------------- | ----------- | -------------- |
| `process.runtime.jvm.threads.count` | UpDownCounter | `{thread}` | Number of executing threads. |
| `process.runtime.jvm.threads.count` | UpDownCounter | `{thread}` | Number of executing platform threads. |
<!-- endsemconv -->

<!-- semconv metric.process.runtime.jvm.threads.count(full) -->
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Google Compute Engine

**Type:** `gcp.gce`

**Description:** Resource attributes for GCE instances.

<!-- semconv gcp.gce -->
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| `gcp.gce.instance.name` | string | The instance name of a GCE instance. This is the value provided by `host.name`, the visible name of the instance in the Cloud Console UI, and the prefix for the default hostname of the instance as defined by the [default internal DNS name](https://cloud.google.com/compute/docs/internal-dns#instance-fully-qualified-domain-names). | `instance-1`; `my-vm-name` | Recommended |
| `gcp.gce.instance.hostname` | string | The hostname of a GCE instance. This is the full value of the default or [custom hostname](https://cloud.google.com/compute/docs/instances/custom-hostname-vm). | `my-host1234.example.com`; `sample-vm.us-west1-b.c.my-project.internal` | Recommended |
<!-- endsemconv -->

0 comments on commit cb03be4

Please sign in to comment.