Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename process.runtime.jvm.* namespace to simply jvm.* #227

Closed
trask opened this issue Aug 2, 2023 · 5 comments · Fixed by #241
Closed

Rename process.runtime.jvm.* namespace to simply jvm.* #227

trask opened this issue Aug 2, 2023 · 5 comments · Fixed by #241
Assignees

Comments

@trask
Copy link
Member

trask commented Aug 2, 2023

From @jsuereth #20 (review):

We want namespacing to be "reasonably unique" and minimal.

This will help with keeping the attribute names under control as well, now that we are namespacing them also.

@trask
Copy link
Member Author

trask commented Aug 2, 2023

comment from @tigrannajaryan #20 (comment)

What is our general strategy with regards to choosing top-level namespaces? Is every language free to put anything in the top-level namespace (like Java does with 'jvm.`)? My concern is that this is going to result in highly crowded top-level that is going to be hard to manage. How do we make sure languages don't step on each other's toes? A language can choose to use a namespace and later it turns out to be also needed for another language but can mean something different.

I would like to understand what the policy is in general and I don't see it mentioned anywhere.

@trask
Copy link
Member Author

trask commented Aug 2, 2023

I would like to understand what the policy is in general

my guess(?) is that it is up to the discretion of @open-telemetry/specs-semconv-maintainers to approve any new top-level namespaces.

@tigrannajaryan are you looking for something more than this?

@jsuereth
Copy link
Contributor

jsuereth commented Aug 7, 2023

@tigrannajaryan may still be out on Holiday. His request, in the TC, was that we set a consistent definition of what makes a namespace and what doens't.

E.g. we should haven't a metric namespace runtime.process.jvm and an attribute namespace jvm. We should consistently have namespace rules so that like things have like namespaces.

THis is where the "reasonably unique" language came from, we just need to codify it in a PR.

@liustanley
Copy link

Are there any future plans of making the runtime metric prefix consistent across the different language instrumentations? All of the other language instrumentation libraries use process.runtime.[language].

@trask
Copy link
Member Author

trask commented Nov 1, 2023

hi @liustanley, I think this is a good question, can you open a new issue for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants