-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add namespace to jvm metric attributes #20
Conversation
47e1e66
to
a5b994b
Compare
c64aa2e
to
4d106f3
Compare
From JVM runtime metrics stability WG, I think we had agreed on these attribute names if the outcome of #51 is to namespace metric attributes |
4d106f3
to
c76cb09
Compare
semantic_conventions/metrics/process-runtime-jvm-metrics-experimental.yaml
Outdated
Show resolved
Hide resolved
0a1eb2e
to
648f5c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I posted a comment expressing a preference for a difference strategy, but like this as well if folks are aligned that gc. / memory. / thread. / buffer. are generic enough concepts to not place in a JVM namespace.
I also have some concerns with the broad |
648f5c8
to
bd74b46
Compare
@joaopgrassi fixed the obvious things |
2d3a74a
to
94bec14
Compare
@joaopgrassi we decided to qualify all metrics with "jvm." except for thread.daemon - everything should be addressed now |
8ce97dd
to
4ef4cb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Primarily, the schema file should NOT be in the schemas
directory, we only create that one when cutting a release.
However, additionally to this attribute rename, we should be renaming the JVM metric namespace as a whole to be jvm.*
based on a lot of discussions.
Particularly - We want namespacing to be "reasonably unique" and minimal. process.runtime
just doesn't make any sense for the JVM. The JVM is not bound to one process, depending on which architecture it's run on.
b4445f9
to
4540127
Compare
While I still think we should entertain changing the metrics |
@tigrannajaryan are you ok with unblocking this PR and moving the discussion to #227? or would you like to get resolution on #227 before merging this? |
/easycla |
d07c5f7
to
2149c65
Compare
It's been a while since I reviewed this, given I think things changed, I will look at it again
Depending which one merges first (#241) one of them will have to adapt either the metric names or the attribute names in the changelog/schema file |
@tigrannajaryan we have shortened the metric names also now from if this resolves your concern, can you unblock? thx |
Successor of open-telemetry/opentelemetry-specification#3464 (review)
Fixes #61