Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net.peer.ip and net.host.ip to deprecated yaml #1029

Merged
merged 7 commits into from
May 10, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .chloggen/deprecated-net.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Use this changelog template to create an entry for release notes.
#
# If your change doesn't affect end users you should instead start
# your pull request title with [chore] or use the "Skip Changelog" label.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: deprecation
dyladan marked this conversation as resolved.
Show resolved Hide resolved

# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db)
component: net

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add deprecated net attributes to registry
dyladan marked this conversation as resolved.
Show resolved Hide resolved

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
# The values here must be integers.
issues: [1029]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: These attributes were deprecated in 1.13
2 changes: 2 additions & 0 deletions docs/attributes-registry/network.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,10 @@ These attributes may be used for any network related operation.

| Attribute | Type | Description | Examples | Stability |
| ---------------------- | ------ | -------------------------------------------------------------------------------------- | -------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------- |
| `net.host.ip` | string | Deprecated, use `network.local.address`. | `192.168.0.1` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `network.local.address`. |
| `net.host.name` | string | Deprecated, use `server.address`. | `example.com` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `server.address`. |
| `net.host.port` | int | Deprecated, use `server.port`. | `8080` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `server.port`. |
| `net.peer.ip` | string | Deprecated, use `network.peer.address`. | `127.0.0.1` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `network.peer.address`. |
| `net.peer.name` | string | Deprecated, use `server.address` on client spans and `client.address` on server spans. | `example.com` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `server.address` on client spans and `client.address` on server spans. |
| `net.peer.port` | int | Deprecated, use `server.port` on client spans and `client.port` on server spans. | `8080` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `server.port` on client spans and `client.port` on server spans. |
| `net.protocol.name` | string | Deprecated, use `network.protocol.name`. | `amqp`; `http`; `mqtt` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `network.protocol.name`. |
Expand Down
12 changes: 12 additions & 0 deletions model/registry/deprecated/network.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,24 @@ groups:
stability: experimental
brief: Deprecated, use `server.port` on client spans and `client.port` on server spans.
examples: [8080]
- id: peer.ip
type: string
deprecated: "Replaced by `network.peer.address`."
stability: experimental
brief: Deprecated, use `network.peer.address`.
examples: '127.0.0.1'
- id: host.name
type: string
deprecated: "Replaced by `server.address`."
stability: experimental
brief: Deprecated, use `server.address`.
examples: ['example.com']
- id: host.ip
type: string
deprecated: "Replaced by `network.local.address`."
stability: experimental
brief: Deprecated, use `network.local.address`.
examples: '192.168.0.1'
- id: host.port
type: int
deprecated: "Replaced by `server.port`."
Expand Down
Loading