[chore] Render attribute name on foot notes #1583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
approved these changes
Nov 15, 2024
mx-psi
approved these changes
Nov 15, 2024
lmolkova
reviewed
Nov 15, 2024
| SHOULD include the [application root](/docs/http/http-spans.md#http-server-definitions) if there is one. | ||
|
|
||
| **[5]:** The value SHOULD be normalized to lowercase. | ||
| **[5] `network.protocol.name`:** The value SHOULD be normalized to lowercase. | ||
|
|
||
| **[6]:** If not `http` and `network.protocol.version` is set. |
There was a problem hiding this comment.
wonder if we should also render the attribute name on requirement level notes?
I'd actually love to merge them eventually to one note in markdown with more structure (not for this PR)
lmolkova
approved these changes
Nov 15, 2024
jsuereth
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Renders the attribute name on the generated table foot notes. In my opinion this makes looking at the notes easier, as one usually needs to go back and forth to remember what the [x] index refers to.
Merge requirement checklist
[chore]