[chore] Add lightweight make check target #1586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
approved these changes
Nov 16, 2024
codeboten
reviewed
Nov 16, 2024
Makefile
Outdated
| @@ -41,6 +41,10 @@ DOCKER_USER=$(shell id -u):$(shell id -g) | |||
| all: install-tools markdownlint markdown-link-check misspell table-check compatibility-check schema-check \ | |||
| check-file-and-folder-names-in-docs | |||
|
|
|||
| .PHONY: all-skip-link-check | |||
| all: install-tools markdownlint misspell table-check compatibility-check schema-check \ | |||
There was a problem hiding this comment.
This should be updated to all-skip-link-check
There was a problem hiding this comment.
Fixed when I renamed the target in 8ccd778
The link check is super slow, but the rest of the `all` checks are useful while iterating on a change. This PR adds a new target called `check` that depends on all the same targets minus the link check.
braydonk
force-pushed
the
skip_link_check
branch
from
d8d440f
to
8ccd778
Compare
braydonk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The link check is super slow, but the rest of the
allchecks are useful while iterating on a change. This PR adds a new target that depends on all the same targets minus the link check.