-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry.distro.name and telemetry.distro.version #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, assuming this is already used / prototyped by the Java instrumentation distributions.
No, it's not prototyped yet. We wanted to have feedback from the spec first - I'll do a prototype now 😄 |
Do you have any recommendation how to call official distributions? There is a strict recommendation what to set for sdk.name attribution **[1]:** The OpenTelemetry SDK MUST set the `telemetry.sdk.name` attribute to `opentelemetry`.
If another SDK, like a fork or a vendor-provided implementation, is used, this SDK MUST set the
`telemetry.sdk.name` attribute to the fully-qualified class or module name of this SDK's main entry point
or another suitable identifier depending on the language. |
I would be in favor of |
Then probably we should also rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that proposal.
With a strong +1 on #178 (comment).
So, let's add a similar note for telemetry.auto.name
.
@zeitlinger How do we want to proceed with that? Do you mind updating the PR to the proposal from above? (updating to |
yes, that's a good idea - done 😄 |
12b4f5f
to
5a12795
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving (new name distro
)
@zeitlinger can you update the PR title and description to reflect this change?
telemetry.auto.name
resource attribute telemetry.distro.name
and add telemetry.distro.version
resource attribute
telemetry.auto.name
resource attribute telemetry.distro.name
and add telemetry.distro.version
resource attributeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @zeitlinger Please add a new schema file with a schema transformation for this change (like here).
I would like to rise this topic once more time before merging. |
5a12795
to
e27cc56
Compare
@zeitlinger This still needs a telemetry schema file |
e27cc56
to
c684726
Compare
@open-telemetry/specs-semconv-maintainers I guess this can be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema changes should be reflected in https://github.com/open-telemetry/semantic-conventions/blob/main/schema-next.yaml and not in a new file IIRC.
Also, was the comment from @Kielek addressed?
Do you have any recommendation how to call official distributions?
There is a strict recommendation what to set for sdk.name attribution**[1]:** The OpenTelemetry SDK MUST set the `telemetry.sdk.name` attribute to `opentelemetry`. If another SDK, like a fork or a vendor-provided implementation, is used, this SDK MUST set the `telemetry.sdk.name` attribute to the fully-qualified class or module name of this SDK's main entry point or another suitable identifier depending on the language.
I would like to rise this topic once more time before merging.
7972952
to
6241d95
Compare
@joaopgrassi @Kielek thanks for the feedback 😄 Added a section on naming the official distro & fixed the schema file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving the broad number of approvals and the latest change (even if minor) I think others need to look at it again.
telemetry.auto.name
resource attributetelemetry.distro.name
telemetry.distro.version
resource attribute