Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http.*.duration to http.*.request.duration #224

Merged
merged 7 commits into from
Aug 3, 2023

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Aug 1, 2023

Fixes #222

@lmolkova lmolkova requested review from a team August 1, 2023 03:37
@jsuereth jsuereth merged commit fa2d7f9 into open-telemetry:main Aug 3, 2023
8 checks passed
bryce-b pushed a commit to bryce-b/semantic-conventions that referenced this pull request Aug 8, 2023
@jack-berg
Copy link
Member

Is this change allowed given that http.server.duration is marked as Feature freeze? Or at least is both experimental and feature freeze. As mentioned here, I'm confused how a single metric have have both statuses simultaneously.

@reyang
Copy link
Member

reyang commented Aug 8, 2023

Is this change allowed given that http.server.duration is marked as Feature freeze? Or at least is both experimental and feature freeze (to control the scope). As mentioned here, I'm confused how a single metric have have both statuses simultaneously.

Yes, feature-freeze is just saying "we don't accept new features", it has nothing to do with breaking changes, we can (in theory) break everything as long as it is experimental https://github.com/open-telemetry/opentelemetry-specification/blob/ad1537a46eb856eeb915786fd7cf81e07bdeb426/specification/document-status.md?plain=1#L19

@jack-berg
Copy link
Member

Got it - makes sense. I wasn't thinking about feature freeze correctly.

rapphil pushed a commit to rapphil/semantic-conventions that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename http.*.duration metrics to http.*.request.duration
8 participants