HTTP version should be 2 and 3 instead of 2.0 and 3.0 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Aug 4, 2023
joaopgrassi
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
I wonder if https://github.com/open-telemetry/semantic-conventions/blob/main/model/trace/general.yaml#L49 shouldn't be an enum 🤔
great point! the problem is that it's a generic one and there could be protocols with version |
AlexanderWert
approved these changes
Aug 5, 2023
reyang
approved these changes
Aug 6, 2023
bryce-b
pushed a commit
to bryce-b/semantic-conventions
that referenced
this pull request
Aug 8, 2023
rapphil
pushed a commit
to rapphil/semantic-conventions
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
HTTP protocol has the following versions:
HTTP/1.0- RFC1945HTTP/1.1- RFC2616 and its updatesHTTP/2- RFC7540HTTP/3- RFC9114This PR updates examples of network protocol versions in HTTP spec to use this set of versions.
Merge requirement checklist