-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit HTTP request method cardinality: canonical method (Option B/D) #34
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,11 +4,51 @@ groups: | |
brief: "Describes HTTP attributes." | ||
prefix: http | ||
attributes: | ||
- id: request.method | ||
type: string | ||
requirement_level: required | ||
brief: 'HTTP request method.' | ||
- id: request.canonical_method | ||
type: | ||
allow_custom_values: true | ||
members: | ||
- id: connect | ||
value: "CONNECT" | ||
brief: 'CONNECT method.' | ||
- id: delete | ||
value: "DELETE" | ||
brief: 'DELETE method.' | ||
- id: get | ||
value: "GET" | ||
brief: 'GET method.' | ||
- id: head | ||
value: "HEAD" | ||
brief: 'HEAD method.' | ||
- id: options | ||
value: "OPTIONS" | ||
brief: 'OPTIONS method.' | ||
- id: patch | ||
value: "PATCH" | ||
brief: 'PATCH method.' | ||
- id: post | ||
value: "POST" | ||
brief: 'POST method.' | ||
- id: put | ||
value: "PUT" | ||
brief: 'PUT method.' | ||
- id: trace | ||
value: "TRACE" | ||
brief: 'TRACE method.' | ||
- id: other | ||
value: "other" | ||
brief: 'Any custom HTTP method that the instrumentation has no prior knowledge of.' | ||
brief: 'Canonical HTTP request method.' | ||
examples: ["GET", "POST", "HEAD"] | ||
note: | | ||
HTTP request method SHOULD be one of the methods defined in [RFC9110](https://www.rfc-editor.org/rfc/rfc9110.html#name-methods) | ||
or the PATCH method defined in [RFC5789](https://www.rfc-editor.org/rfc/rfc5789.html). | ||
Instrumentation MAY additionally support the closed set of custom HTTP methods defined in | ||
[HTTP method registry](https://www.iana.org/assignments/http-methods/http-methods.xhtml) or a private registry. | ||
If the HTTP request method is not known to the instrumentation, it MUST set the `http.request.canonical_method` attribute to `other` and SHOULD | ||
populate the exact method passed by client on `http.request.method` attribute. | ||
|
||
HTTP method names are case-sensitive and `http.request.canonical_method` attribute value MUST match a standard (or documented elsewhere) HTTP method name exactly. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we say it must match the enum we defined here? Otherwise it seems much like another open attribute if the standard is not clearly defined by OTel. |
||
- id: response.status_code | ||
type: int | ||
requirement_level: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this allow custom values though? If we want to offer this as a "control" for cardinality, I feel maybe we have to lock it down?