-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite HTTP server definitions section #423
Merged
AlexanderWert
merged 8 commits into
open-telemetry:main
from
lmolkova:http-server-definitions
Oct 26, 2023
Merged
Rewrite HTTP server definitions section #423
AlexanderWert
merged 8 commits into
open-telemetry:main
from
lmolkova:http-server-definitions
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
http-server-definitions
branch
3 times, most recently
from
October 18, 2023 18:18
95ab752
to
bce2545
Compare
trask
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is very helpful
lmolkova
force-pushed
the
http-server-definitions
branch
from
October 18, 2023 19:51
c36c33b
to
2ea0b86
Compare
trask
reviewed
Oct 18, 2023
lmolkova
force-pushed
the
http-server-definitions
branch
2 times, most recently
from
October 20, 2023 00:10
64ee05a
to
b3edf6c
Compare
mateuszrzeszutek
approved these changes
Oct 20, 2023
lmolkova
force-pushed
the
http-server-definitions
branch
from
October 23, 2023 20:15
69a480b
to
b2d0e2d
Compare
After discussion with @trask:
Also, added |
trask
approved these changes
Oct 23, 2023
mateuszrzeszutek
approved these changes
Oct 24, 2023
jsuereth
approved these changes
Oct 24, 2023
lmolkova
force-pushed
the
http-server-definitions
branch
from
October 24, 2023 21:49
d1cb03c
to
071c834
Compare
AlexanderWert
approved these changes
Oct 25, 2023
joaopgrassi
reviewed
Oct 25, 2023
lmolkova
force-pushed
the
http-server-definitions
branch
from
October 25, 2023 17:03
071c834
to
07826cb
Compare
1 task
joaopgrassi
added a commit
that referenced
this pull request
Oct 30, 2023
Co-authored-by: Joao Grassi <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
Changes
Merge requirement checklist
schema-next.yaml