Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make url.scheme opt in for HTTP client metrics and make server.port required #459

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Make url.scheme opt in for HTTP client metrics and make server.port required #459

merged 5 commits into from
Oct 31, 2023

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Oct 27, 2023 •
edited
Loading

Fixes #450

Changes

Merge requirement checklist

@lmolkova lmolkova mentioned this pull request Oct 27, 2023
Closed
trask
trask approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmolkova and I checked, and server.port is the last HTTP semconv attribute that has (had) a default value

@lmolkova lmolkova marked this pull request as ready for review October 27, 2023 23:22
@lmolkova lmolkova requested review from a team October 27, 2023 23:22
@lmolkova lmolkova mentioned this pull request Oct 30, 2023
Merged
@trask trask mentioned this pull request Oct 31, 2023
Merged
2 tasks
@AlexanderWert AlexanderWert merged commit a8535bd into open-telemetry:main Oct 31, 2023
9 checks passed
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Oct 31, 2023
Merged
@trask trask mentioned this pull request Oct 31, 2023
Closed
4 tasks
@lmolkova lmolkova mentioned this pull request Nov 16, 2023
Closed
@antonfirsov antonfirsov mentioned this pull request Mar 11, 2024
Merged
4 tasks
@antonfirsov antonfirsov mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

url.scheme is present on HTTP client metrics but not HTTP client spans
6 participants
@lmolkova @trask @AlexanderWert @joaopgrassi @mateuszrzeszutek @arminru