Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http.server.active_requests metric to http.server.current_requests #465

Closed

Conversation

trask
Copy link
Member

@trask trask commented Oct 28, 2023

Fixes #202

Note: this metric is not (currently) in our initial stability plan, but I'm wondering now if it should be, so that this breaking change can be covered by the OTEL_SEMCONV_STABILITY_OPT_IN flag.

EDIT: Nevermind, closing this PR, I think the naming convention here is still unclear. It would be good to have consistency across:

  • jvm.thread.count
  • jvm.class.count
  • http.server.current_requests

which ties into #211 and #260 (comment).

Changes

Renames http.server.active_requests metric to http.server.current_requests.

Merge requirement checklist

@trask trask force-pushed the rename-http-server-active-requests branch from bf50b54 to 9925030 Compare October 28, 2023 19:50
@trask trask closed this Oct 28, 2023
@trask trask deleted the rename-http-server-active-requests branch October 28, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Rename http.server.active_requests to http.server.current_requests?
1 participant