Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change Erlang managed thread attribute to be the Erlang process #491

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

tsloughter
Copy link
Member

When a PR to add these attributes to otel Erlang/Elixir was opened it was pointed out the example is wrong and to match the other examples of what a "managed" thread is this should be the Erlang process id and not the scheduler id which is an OS thread.

Changes

Since this is just an example change I haven't added it to the changelog. Happy to add one.

Merge requirement checklist

@tsloughter tsloughter requested review from a team November 4, 2023 18:09
@arminru arminru merged commit 65a3cc7 into open-telemetry:main Nov 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants