system: shared IO direction attributes #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Nov 16, 2023
|
This PR should be ready for proper review. I learned my lesson and will add the changelog entry and schema changes after the PR has been reviewed and everyone feels good about it (dealing with the constant conflicts there while getting the PR ready is nasty) |
ChrsMark
approved these changes
Nov 20, 2023
AlexanderWert
approved these changes
Nov 20, 2023
dmitryax
approved these changes
Nov 22, 2023
AlexanderWert
approved these changes
Nov 22, 2023
3 tasks
braydonk
added a commit
to braydonk/semantic-conventions
that referenced
this pull request
Nov 30, 2023
Followup to PR open-telemetry#530 to add the changes to the changelog and schema.
3 tasks
pyohannes
pushed a commit
to pyohannes/semantic-conventions
that referenced
this pull request
Jan 17, 2024
Co-authored-by: Alexander Wert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue for this but I can make one if we need to track it somewhere.
Changes
This PR adds new global attributes
network.io.directionanddisk.io.direction. These attributes will replace thesystemnamespaced versions of these metrics such that they can be reused in theprocessnamespace as well.Merge requirement checklist