-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark JVM metrics stable #569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
jvm-metrics-stable
branch
from
November 30, 2023 15:49
456d34b
to
ec636c4
Compare
Resolves #552. |
jack-berg
approved these changes
Nov 30, 2023
trask
force-pushed
the
jvm-metrics-stable
branch
from
November 30, 2023 16:00
eb868fb
to
723976b
Compare
mateuszrzeszutek
approved these changes
Nov 30, 2023
breedx-splk
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻
AlexanderWert
approved these changes
Dec 1, 2023
joaopgrassi
approved these changes
Dec 1, 2023
1 task
pyohannes
pushed a commit
to pyohannes/semantic-conventions
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Marks JVM metrics stable.
Java Instrumentation 1.32.0 already implements these behind
OTEL_SEMCONV_STABILITY_OPT_IN=jvm
, and we are planning to enable them by default in upcoming Java Instrumentation 2.0: open-telemetry/opentelemetry-java-instrumentation#9963Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.